[Winpcap-users] Various fixups

[deadchicken]

Compiles and works wonderfully!

---
"The same thing we do every night, Pinky. Try to take over the world!"

Gianluca Varenni wrote:
> Hi.
> 
> I played a bit with the patch you sent, with the following outcome:
> - the modified files seem to compile smoothly both with GCC and Visual C 
> 6 (used normally to compile the WinPcap DLLs)
> - due to licensing issues (or better, lack of), I cannot use the 
> gai_strerror.c file you sent, which is probably taken out of the 
> Microsoft include file WS2tcpip.h. I took an implementation of that 
> function from the freeBSD source code (we do the same for other 
> functions in wpcap\libpcap\Win32\Src) and modified some bits to make it 
> compile.
> - regarding the weird patch for struct bpf_stat, it's a problem related 
> to a duplicated definition of that structure in multiple include files, 
> for which a quite ugly #ifdef was added years ago in packet32.h (i.e. 
> it's not a problem with MingW per se). In any case, an easy and safe 
> patch to the problem is to add a forward declaration of struct bpf_stat 
> inside packet32.h (since the function declarations in this file only use 
> a pointer to this struct). Any other patch for this issue involved 
> adding some #ifdef's here and there in various include files (and this 
> could cause side effects that I'd prefer to avoid).
> - in the GNU makefile for packet.dll, it's not necessary to define 
> HAVE_REMOTE (since the remote stuff is implemented in wpcap.dll)
> 
> All these things have been tested with Cygwin, which should be quite 
> similar to MingW. In any case, attached you can find an updated patch 
> file against WinPcap 3.2a1. The new gai_strerror.c file is included in 
> the patch file. Can you please test it with MingW and tell me if it works?
> 
> To apply the patch, go into the "winpcap" folder, then type "patch -p1 < 
> [path_to_the_diff_file]".
> 
> Have a nice day
> GV
> 
> PS: thanks for the hard work!!